[charts] Refactor LineChart classes structure (@JCQuintas)#21672
Open
github-actions[bot] wants to merge 2 commits intov8.xfrom
Open
[charts] Refactor LineChart classes structure (@JCQuintas)#21672github-actions[bot] wants to merge 2 commits intov8.xfrom
LineChart classes structure (@JCQuintas)#21672github-actions[bot] wants to merge 2 commits intov8.xfrom
Conversation
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
|
Deploy preview: https://deploy-preview-21672--material-ui-x.netlify.app/ Bundle size report
|
Comment on lines
+22
to
+29
|
|
||
| export interface MarkElementOwnerState { | ||
| id: SeriesId; | ||
| isFaded: boolean; | ||
| isHighlighted: boolean; | ||
| classes?: Partial<LineClasses>; | ||
| skipAnimation?: boolean; | ||
| } |
Member
There was a problem hiding this comment.
I don't get why this type is here
Member
There was a problem hiding this comment.
I guess it is because in the BarChart it got moved as well. I first had it removed, so when it was added back it was added on a different place
Member
There was a problem hiding this comment.
Don't think it is a big issue, we will probably remove it when we remove the deprecations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #21648