Skip to content

rawtherapee: move to by-name, refactor, fix #475835#498497

Open
pinpox wants to merge 1 commit intoNixOS:masterfrom
pinpox:rawtherapee-fix-476711
Open

rawtherapee: move to by-name, refactor, fix #475835#498497
pinpox wants to merge 1 commit intoNixOS:masterfrom
pinpox:rawtherapee-fix-476711

Conversation

@pinpox
Copy link
Member

@pinpox pinpox commented Mar 10, 2026 •
edited
Loading

superseeds #476711

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@pinpox pinpox force-pushed the rawtherapee-fix-476711 branch 2 times, most recently from 5d5ac20 to 975e433 Compare March 10, 2026 09:57
@pinpox pinpox mentioned this pull request Mar 10, 2026
Open
13 tasks
@pinpox pinpox force-pushed the rawtherapee-fix-476711 branch from 975e433 to 3b00082 Compare March 10, 2026 10:03
SFrijters
SFrijters reviewed Mar 10, 2026
View reviewed changes
@pinpox pinpox force-pushed the rawtherapee-fix-476711 branch 2 times, most recently from dfaf1a7 to a47f5c2 Compare March 10, 2026 10:14
@nixpkgs-ci nixpkgs-ci bot requested review from 2chilled and jcumming March 10, 2026 10:20
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Mar 10, 2026
@pinpox pinpox force-pushed the rawtherapee-fix-476711 branch from a47f5c2 to 3deed16 Compare March 10, 2026 10:22
@pinpox
Copy link
Member Author

pinpox commented Mar 10, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 498497
Commit: 3deed16351e2582abd1a1a9cc14530a7d995650a

x86_64-linux

✅ 2 packages built:
  • photoprism
  • rawtherapee

@pinpox pinpox force-pushed the rawtherapee-fix-476711 branch from 3deed16 to 99272b9 Compare March 10, 2026 11:30
@betalars
Copy link

betalars commented Mar 10, 2026

I don't know if there's a label for that.
But this fixes a crash on startup. So I'd be very thankful if this gets high priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@2chilled 2chilled Awaiting requested review from 2chilled

@jcumming jcumming Awaiting requested review from jcumming

1 more reviewer

@SFrijters SFrijters SFrijters left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pinpox @betalars @SFrijters